Post

If you are totally against setting state in a useEffect, how would you recommend doing this kind of thing? Assume a SPA.

I _assume_ people mean doing it synchronously in the effect, but I could be missing something

yea

Yeah, folks are getting from something that state setting in a useEffect is bad, period. So I end up getting even when it's something like this. I certainly agree sync setting is bad, but data loading like this is fine, IMHO. RQ is certainly nicer, but not required.

No idea where this is coming from. Setting state unconditionally during the synchronous portion of useEffect is bad, for the same reason that setting state unconditionally during render is bad (infinite render loop). Setting state asynchronously eg due to timer/subscription is fine.

An async effect is generally a really bad idea though. Assuming it had actual deps, as it would for a real use-case, you’d easily end up w race conditions. Earlier promises can resolve later. You’re really better off using a library like react-query, Relay, etc.

Yes, I absolutely agree. What I’m saying is that many developers struggle to understand the difference. It’s a reasonable mistake to make. It “looks” like the code is “inside” the effect. The lines literally are. We should do better helping people understand the fundamentals.