Post

I really do like this talk, and while our tooling has evolved and improved over time, the core ideas are still just as relevant today.

Patrick Dubroy@dubroy.com

"How Jane Street does code review" by @ianthehenry.bsky.social → www.janestreet.com/tech-talks/.... Not just about code review; has some deeper ideas: • explicitly modeling *what the user has seen* and using that in the UI • subtle implementation decisions (eg CR comments) can affect collaboration

This would be great! I would love to hear how it evolved over time, especially how it scaled once the number of developers increased.

0 reposts0 likes

I think the takeaway from this quote has changed my view on code reviews forever: "When I’m working on a branch, it sort of feels like this is my feature. [...] when other people push to it, [...] that goes away. [...] which is good. I mean, all code becomes someone else’s eventually"