Post

Alright GANG #ElixirLang, what do we think about this pattern? See dev.to/martinthenth...

@sasajuric.bsky.social

30 Oct 2024

Hard pass. I dislike how things which are strongly related (validation and the corresponding error) are separated so far apart. This is what I do instead 👇

Elixir ▷ Max

@mxgrn.com

Fully agree. I would also consider converting the 2 boolean functions to those that return :ok | {:error, reason}: is_email_address? => validate_email_address is_available => check_availability It's also future-proof if additional error reasons pop up. You may say I generally dislike booleans :)

30/10/24, 7:05 am0 reposts1 like

Saša Jurić

@sasajuric.bsky.social

30 Oct 2024

I think having boolean funs is fine, they might be useful in other scenarios. The `validate` helper is a simple way of converting a boolean to ok/error.

Elixir ▷ Max

@mxgrn.com

30 Oct 2024

oh sure, they have their place. Also, I'd use your approach if the boolean funs would come from a lib, for example.

Saša Jurić

@sasajuric.bsky.social

30 Oct 2024

Yeah, we agree then