Post

Sam Rose
@samwho.dev

I got an itch to play with some ideas I’ve had around code review. Also decided to completely vibe code it with Claude Code to become more familiar with the strengths and weaknesses of working like this. Idea is you can sort files topologically, and symbols modified in this PR are highlighted.

Nick Williams
@wicky.nillia.ms

Sorting topologically is an excellent idea here. Seems like a painfully obvious improvement in retrospect! As the best ideas are. How does it handle things that are not part of the module graph? Eg a random md file

Sam Rose
@samwho.dev

It currently doesn’t, but one of the things I’d like to do is to group files into subgraphs if it finds multiple graphs without a connection.

Sam Rose
@samwho.dev

I think you could do even better than topological sorting if you had enough static information and calculate all of the paths through the modified code, so you could review logical flows individually. It has potential to grow explosively but that could be a signal the PR is too complex.

0 reposts0 likes

Sam Rose
@samwho.dev

I really wish GitHub cared about the PR review experience enough to experiment like this. I feel like it hasn’t changed in around a decade. I suspect with agents writing so much new code the review process is going to quickly become the bottleneck.

Nick Williams
@wicky.nillia.ms

Definitely. And hard agree, GitHub has become stagnant feature wise. Sometimes they make reviewing code so difficult. I was reviewing a PR recently that had 500 changes (type changed, meaning every impl had a one line change), after a certain point you have to click to see the diff for each file 😭

Aran Wilkinson
@aran.dev

I hate the Github PR Review experience especially when combined with developers who rebase and force push. Makes a annoying experience even worse